Closed hbacila closed 4 years ago
Merging #131 into master will increase coverage by
2.46%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #131 +/- ##
============================================
+ Coverage 85.31% 87.77% +2.46%
- Complexity 492 500 +8
============================================
Files 35 35
Lines 1920 1914 -6
Branches 299 299
============================================
+ Hits 1638 1680 +42
+ Misses 144 99 -45
+ Partials 138 135 -3
Flag | Coverage Δ | Complexity Δ | |
---|---|---|---|
#integration | 48.72% <ø> (+38.13%) |
256.00 <ø> (+208.00) |
|
#karma | 96.55% <100.00%> (+3.83%) |
0.00 <0.00> (ø) |
|
#unittests | 83.88% <ø> (ø) |
484.00 <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 56c4b12...d49f8c7. Read the comment docs.
Use
PreviewServlet
from cif-core-components to prepare and redirect to preview Url.This PR is used in conjunction with https://github.com/adobe/aem-core-cif-components/pull/305
Description
The preview with product / category now uses the
PreviewServlet
to construct the preview Url based onUrlProvider
configuration. The servlet will also do a redirect to the preview Url.The preview servlet url is
/bin/wcm/cif.PREVIEW_SELECTOR.html
wherePREVIEW_SELECTOR
is:previewproduct
- for Product previewpreviewcategory
- for Category previewRelated Issue
https://github.com/adobe/aem-core-cif-components/pull/305
Motivation and Context
Current implementation does not satisfy custom UrlProvider templates.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: