adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1404 - Editing support for cq:catalogPath #132

Closed cjelger closed 4 years ago

cjelger commented 4 years ago

How Has This Been Tested?

Extended unit tests and manually tested.

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #132 into master will decrease coverage by 0.03%. The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #132      +/-   ##
============================================
- Coverage     87.45%   87.41%   -0.04%     
- Complexity      495      497       +2     
============================================
  Files            35       35              
  Lines          1905     1907       +2     
  Branches        293      296       +3     
============================================
+ Hits           1666     1667       +1     
  Misses          106      106              
- Partials        133      134       +1     
Flag Coverage Δ Complexity Δ
#integration 48.29% <0.00%> (-0.63%) 252.00 <0.00> (-1.00)
#karma 92.71% <ø> (ø) 0.00 <ø> (ø)
#unittests 83.82% <92.85%> (-0.04%) 481.00 <1.00> (+2.00) :arrow_down:
Impacted Files Coverage Δ Complexity Δ
...rtual/catalog/data/impl/ProductBindingCreator.java 77.01% <83.33%> (+0.18%) 14.00 <0.00> (ø)
.../commerce/graphql/search/CatalogSearchSupport.java 83.78% <100.00%> (+2.53%) 12.00 <0.00> (+2.00)
...be/cq/commerce/virtual/catalog/data/Constants.java 100.00% <100.00%> (ø) 1.00 <1.00> (ø)
...a/impl/CatalogDataResourceProviderManagerImpl.java 80.84% <0.00%> (-0.09%) 44.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1107f8b...4ac71f8. Read the comment docs.