adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1162 - Pickers opened for page preview should honor cq:catalogPath #134

Closed LSantha closed 4 years ago

LSantha commented 4 years ago

Description

When the PDP preview and PLP preview actions open product picker and category picker these pickers should respect the cq:catalogPath property for the site and open with root path defined by this property.

Related Issue

CIF-1162

How Has This Been Tested?

With JUnit and, manually.

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #134 into master will decrease coverage by 0.17%. The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #134      +/-   ##
============================================
- Coverage     87.67%   87.50%   -0.18%     
- Complexity      497      500       +3     
============================================
  Files            35       35              
  Lines          1907     1920      +13     
  Branches        296      299       +3     
============================================
+ Hits           1672     1680       +8     
- Misses          101      105       +4     
- Partials        134      135       +1     
Flag Coverage Δ Complexity Δ
#integration 48.72% <92.30%> (+0.43%) 256.00 <1.00> (+4.00)
#karma 92.71% <ø> (-3.32%) 0.00 <ø> (ø)
#unittests 83.88% <92.30%> (+0.06%) 484.00 <1.00> (+3.00)
Impacted Files Coverage Δ Complexity Δ
...e/renderconditions/IsProductDetailPageServlet.java 92.85% <90.90%> (-0.70%) 13.00 <1.00> (+2.00) :arrow_down:
...rce/renderconditions/IsProductListPageServlet.java 100.00% <100.00%> (ø) 8.00 <0.00> (+1.00)
...omponents/common/cifpicker/clientlibs/cifpicker.js 80.00% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
.../commerce/graphql/search/CatalogSearchSupport.java 86.48% <0.00%> (+2.70%) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7795c2f...de59cac. Read the comment docs.