adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

Clean-up the actions and the properties page for the product binding #136

Closed laurentiumagureanu closed 4 years ago

laurentiumagureanu commented 4 years ago

Description

Clean-up the actions and the properties page for the product binding

Related Issue

Motivation and Context

Some actions for the product binding don't make sense anymore, now that the product binding is created automatically. The "create", "move", "publish", "unpublish" and "delete" must be removed

The "properties" action can stay, but the properties page must be updated to contain the following fields:

Binding title - read only Configuration reference - a link to the Context Configuration that manages this binding. Ideally this link can open the actual configuration for editing.

How Has This Been Tested?

Screenshots (if appropriate):

image image

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #136 into master will decrease coverage by 2.03%. The diff coverage is 89.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
- Coverage     87.66%   85.62%   -2.04%     
  Complexity      515      515              
============================================
  Files            37       38       +1     
  Lines          1978     1997      +19     
  Branches        310      316       +6     
============================================
- Hits           1734     1710      -24     
- Misses          104      142      +38     
- Partials        140      145       +5     
Flag Coverage Δ Complexity Δ
#integration 10.12% <0.00%> (-37.40%) 48.00 <0.00> (-211.00)
#karma 96.55% <ø> (ø) 0.00 <ø> (ø)
#unittests 84.01% <89.47%> (+0.05%) 507.00 <8.00> (+8.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...atalog/models/impl/ConfigurationReferenceImpl.java 89.47% <89.47%> (ø) 8.00 <8.00> (?)
...mmerce/graphql/core/GraphqlProductViewHandler.java 64.23% <0.00%> (-15.90%) 17.00% <0.00%> (-1.00%)
...cq/commerce/graphql/resource/CategoryResource.java 82.14% <0.00%> (-10.72%) 8.00% <0.00%> (-1.00%)
...erce/graphql/resource/GraphqlResourceProvider.java 82.35% <0.00%> (-5.89%) 11.00% <0.00%> (-1.00%)
.../cq/commerce/graphql/resource/ProductResource.java 85.00% <0.00%> (-5.00%) 15.00% <0.00%> (-1.00%)
...mnisearch/ProductsSuggestionOmniSearchHandler.java 85.39% <0.00%> (-4.50%) 12.00% <0.00%> (-2.00%)
...e/renderconditions/IsProductDetailPageServlet.java 81.63% <0.00%> (-4.09%) 13.00% <0.00%> (-1.00%)
...aphql/resource/GraphqlResourceProviderFactory.java 94.00% <0.00%> (-4.00%) 11.00% <0.00%> (-1.00%)
...mmerce/graphql/magento/GraphqlDataServiceImpl.java 91.62% <0.00%> (-1.12%) 66.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0f063c...f9e0ac1. Read the comment docs.