CIF-1485 - The cq:catalogPath restriction not applied to picker when previewing non-empty page

[LSantha]

• make sure that cq:catalogPath is honored also when previewing a page which is already showing a product or category
• improve robustness

Description

The cq:catalogPath property is not honored in picker opened by page preview action on a PDP showing a product or PLP showing a category.

Related Issue

CIF-1485

How Has This Been Tested?

Manually.

Types of changes

• [X] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] I have signed the Adobe Open Source CLA.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [X] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes and the overall coverage did not decrease.
• [X] All unit tests pass on CircleCi.
• [X] I ran all tests locally and they pass.

[codecov[bot]]

Codecov Report

Merging #137 into master will decrease coverage by 0.21%. The diff coverage is 70.00%.

@@             Coverage Diff              @@
##             master     #137      +/-   ##
============================================
- Coverage     87.77%   87.55%   -0.22%     
- Complexity      500      501       +1     
============================================
  Files            35       35              
  Lines          1914     1921       +7     
  Branches        299      300       +1     
============================================
+ Hits           1680     1682       +2     
- Misses           99      103       +4     
- Partials        135      136       +1     

Flag	Coverage Δ	Complexity Δ
#integration	48.87% <70.00%> (+0.14%)	257.00 <1.00> (+1.00)
#karma	?	?
#unittests	?	?

Impacted Files	Coverage Δ	Complexity Δ
...e/renderconditions/IsProductDetailPageServlet.java	85.71% <70.00%> (-7.15%)	14.00 <1.00> (+1.00)	:arrow_down:
.../commerce/graphql/search/CatalogSearchSupport.java	83.78% <0.00%> (-2.71%)	12.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update decd82b...65840a2. Read the comment docs.

[hbacila]

Is this something we should address in add-on as well?

[LSantha]

@hbacila , it may be worth checking if it works for the add-on too. If the action is available in the page editor then it should work correctly. (You can easily see that if you open a PLP/PDP in navigation (to show the page with real category/product) then add editor.html in the URL and check the appropriate preview action in the page editor.)