adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

Show inherited configuration properties in the UI #143

Closed laurentiumagureanu closed 4 years ago

laurentiumagureanu commented 4 years ago

Description

This feature allows creation of configurations that inherit properties (enabled by default) and override just the necessary ones. This is inline with the "inherited properties" pattern used everywhere in AEM.

Related Issue

CIF-1326

Motivation and Context

Alignment with the "inherited properties" pattern used everywhere in AEM.

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #143 into master will increase coverage by 0.09%. The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #143      +/-   ##
============================================
+ Coverage     87.57%   87.66%   +0.09%     
- Complexity      501      515      +14     
============================================
  Files            35       37       +2     
  Lines          1923     1978      +55     
  Branches        300      310      +10     
============================================
+ Hits           1684     1734      +50     
- Misses          103      104       +1     
- Partials        136      140       +4     
Flag Coverage Δ Complexity Δ
#integration 47.51% <5.45%> (-1.31%) 259.00 <2.00> (+2.00) :arrow_down:
#karma 96.55% <ø> (ø) 0.00 <ø> (ø)
#unittests 83.96% <90.90%> (+0.21%) 499.00 <14.00> (+14.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...com/adobe/cq/commerce/utils/ConfigInheritance.java 88.88% <88.88%> (ø) 10.00 <10.00> (?)
...tion/servlets/ConfigurationInheritanceServlet.java 94.73% <94.73%> (ø) 4.00 <4.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2bd3cd6...c89d1ba. Read the comment docs.