adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1598 - CIF does not log Magento errors #151

Closed LSantha closed 3 years ago

LSantha commented 3 years ago

Related Issue

CIF-1598

Motivation and Context

Improve error logging.

How Has This Been Tested?

Manually.

Types of changes

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #151 into master will increase coverage by 0.70%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #151      +/-   ##
============================================
+ Coverage     86.98%   87.68%   +0.70%     
  Complexity      523      523              
============================================
  Files            34       38       +4     
  Lines          1852     1998     +146     
  Branches        316      316              
============================================
+ Hits           1611     1752     +141     
- Misses           99      104       +5     
  Partials        142      142              
Flag Coverage Δ Complexity Δ
#integration 47.00% <0.00%> (-0.03%) 259.00 <0.00> (ø)
#karma 96.55% <ø> (?) 0.00 <ø> (?)
#unittests 84.02% <100.00%> (+<0.01%) 507.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...e/cq/commerce/graphql/resource/ResourceMapper.java 74.31% <100.00%> (+0.23%) 22.00 <0.00> (ø)
...mon/cifproductfield/clientlibs/cifproductpicker.js 97.05% <0.00%> (ø) 0.00% <0.00%> (?%)
...oring/editor/pagepreview/clientlibs/pagepreview.js 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...omponents/common/cifpicker/clientlibs/cifpicker.js 93.33% <0.00%> (ø) 0.00% <0.00%> (?%)
...n/cifcategoryfield/clientlibs/cifcategorypicker.js 97.05% <0.00%> (ø) 0.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c190779...33da760. Read the comment docs.