Closed cjelger closed 3 years ago
Merging #155 into master will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #155 +/- ##
=========================================
Coverage 87.68% 87.69%
Complexity 523 523
=========================================
Files 38 38
Lines 1998 1999 +1
Branches 316 316
=========================================
+ Hits 1752 1753 +1
Misses 104 104
Partials 142 142
Flag | Coverage Δ | Complexity Δ | |
---|---|---|---|
integration | 47.03% <100.00%> (+0.02%) |
259.00 <0.00> (ø) |
|
karma | 96.55% <ø> (ø) |
0.00 <ø> (ø) |
|
unittests | 84.03% <100.00%> (+<0.01%) |
507.00 <0.00> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
.../adobe/cq/commerce/graphql/resource/Constants.java | 0.00% <ø> (ø) |
0.00 <0.00> (ø) |
|
...cq/commerce/graphql/resource/CategoryResource.java | 93.10% <100.00%> (+0.24%) |
9.00 <0.00> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3621b8d...a4210aa. Read the comment docs.
Probably also the empty text for the category field could reflect the new kind of selection id.
@LSantha The empty text is simply Category
so I don't think we need to change that, but I updated the text displayed for that page property in https://github.com/adobe/aem-core-cif-components/pull/429
…ry picker
idAndUrlPath
selection type in pickerDescription
Adds the
idAndUrlPath
to select both the categoryid
andurl_path
in the category picker. For example, the picker would return something like12|men/tops
.This will be processed in https://github.com/adobe/aem-core-cif-components/pull/429
How Has This Been Tested?
Unit tested and manually tested.
Types of changes
Checklist: