Closed LSantha closed 3 years ago
Merging #174 (4eb8cb4) into master (7d56aa8) will increase coverage by
0.16%
. The diff coverage is83.33%
.
@@ Coverage Diff @@
## master #174 +/- ##
============================================
+ Coverage 87.69% 87.86% +0.16%
- Complexity 528 534 +6
============================================
Files 38 38
Lines 2008 2019 +11
Branches 317 319 +2
============================================
+ Hits 1761 1774 +13
Misses 104 104
+ Partials 143 141 -2
Flag | Coverage Δ | |
---|---|---|
integration | 46.90% <61.11%> (+0.09%) |
:arrow_up: |
karma | 96.55% <ø> (ø) |
|
unittests | 84.15% <72.22%> (+0.09%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...a/impl/CatalogDataResourceProviderManagerImpl.java | 82.66% <83.33%> (+1.82%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7d56aa8...4eb8cb4. Read the comment docs.
I think we also need to backport this to 0.9.0 branch. @geertsmichael wrote in #173 they still use 0.9.0 version.
Avoid calling CatalogDataResourceProviderManagerImpl.findDataRoots() when non binding related nodes are created in /var/commerce/products. Added unit test.
Related Issue
CIF-2082
How Has This Been Tested?
Manually, unit tests.
Types of changes
Checklist: