adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-996 - Show the store-related properties in the cloud bound folder… #44

Closed LSantha closed 5 years ago

LSantha commented 5 years ago

With the multi-store bindings in place we also need to show the store-related properties in the cloud bound folder.

Description

Include the custom fields of the bindproducttreewizard in the properties page of ccifrootfolder.

Related Issue

CIF-996

Types of changes

Checklist:

codecov[bot] commented 5 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #44   +/-   ##
=========================================
  Coverage     85.37%   85.37%           
  Complexity      309      309           
=========================================
  Files            18       18           
  Lines          1135     1135           
  Branches        175      175           
=========================================
  Hits            969      969           
  Misses           78       78           
  Partials         88       88
Flag Coverage Δ Complexity Δ
#integration 60.61% <ø> (ø) 208 <ø> (ø) :arrow_down:
#unittests 79.45% <ø> (ø) 287 <ø> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7655a30...b937c00. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #44 into master will increase coverage by 0.3%. The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #44     +/-   ##
===========================================
+ Coverage     85.37%   85.67%   +0.3%     
- Complexity      309      314      +5     
===========================================
  Files            18       18             
  Lines          1135     1145     +10     
  Branches        175      178      +3     
===========================================
+ Hits            969      981     +12     
+ Misses           78       75      -3     
- Partials         88       89      +1
Flag Coverage Δ Complexity Δ
#integration 61.92% <66.66%> (+1.3%) 215 <2> (+7) :arrow_up:
#unittests 79.63% <83.33%> (+0.17%) 292 <3> (+5) :arrow_up:
Impacted Files Coverage Δ Complexity Δ
...a/impl/CatalogDataResourceProviderManagerImpl.java 78.91% <83.33%> (+1.2%) 38 <3> (+5) :arrow_up:
...e/cq/commerce/graphql/resource/ResourceMapper.java 79.19% <0%> (+1.15%) 35% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update caacb94...46a756c. Read the comment docs.