LSantha commented 4 years ago

Description

Currently, the category template has the product list component with dummy data. We want to add a preview feature to enable authors to preview the category page with specific category data

Related Issue

CIF-1066

How Has This Been Tested?

Manually, IT, unit test

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[X] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

codecov[bot] commented 4 years ago

Codecov Report

Merging #72 into master will increase coverage by 0.35%. The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
+ Coverage     86.07%   86.42%   +0.35%     
- Complexity      375      383       +8     
============================================
  Files            24       25       +1     
  Lines          1379     1400      +21     
  Branches        216      219       +3     
============================================
+ Hits           1187     1210      +23     
+ Misses           88       87       -1     
+ Partials        104      103       -1

Flag	Coverage Δ	Complexity Δ
#integration	`54.64% <61.9%> (+0.4%)`	`238 <3> (+5)`	:arrow_up:
#unittests	`81.55% <100%> (+0.28%)`	`361 <7> (+7)`	:arrow_up:

Impacted Files	Coverage Δ	Complexity Δ
...rce/renderconditions/IsProductListPageServlet.java	`100% <100%> (ø)`	`7 <7> (?)`
...e/renderconditions/IsProductDetailPageServlet.java	`93.54% <0%> (+6.45%)`	`11% <0%> (+1%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14ac00a...1e9de8c. Read the comment docs.

LSantha commented 4 years ago

This PR is created along the lines of PR #66 and the actual solution is similar to that.

mhaack commented 4 years ago

Verified

adobe / commerce-cif-connector

CIF-1066 - Preview PLP with real category data #72