adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1230 - CIF "omnisearch" has a pagination issue #92

Closed cjelger closed 4 years ago

cjelger commented 4 years ago

How Has This Been Tested?

Unit tested and locally tested with the LUMA catalog. All 187 LUMA products can be seen in the Asset finder: see the screenshots, we can see all products from A to Z (before the fix, the pagination was broken after 39 products).

Screenshot 2020-01-31 at 16 12 17

Screenshot 2020-01-31 at 16 13 44

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #92 into master will increase coverage by 0.26%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     87.01%   87.27%   +0.26%     
- Complexity      387      394       +7     
============================================
  Files            29       29              
  Lines          1579     1580       +1     
  Branches        226      226              
============================================
+ Hits           1374     1379       +5     
+ Misses          101       98       -3     
+ Partials        104      103       -1     
Flag Coverage Δ Complexity Δ
#integration 54.58% <85.71%> (+8.64%) 239.00 <1.00> (+32.00) :arrow_down:
#karma 92.71% <ø> (-3.32%) 0.00 <ø> (ø)
#unittests 82.78% <100.00%> (+0.08%) 377.00 <3.00> (+2.00) :arrow_down:
Impacted Files Coverage Δ Complexity Δ
...omponents/common/cifpicker/clientlibs/cifpicker.js 80.00% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
...a/impl/CatalogDataResourceProviderManagerImpl.java 77.29% <0.00%> (+2.70%) 36.00% <0.00%> (+3.00%) :arrow_down:
...atalog/admin/impl/CatalogIdentifierDatasource.java 100.00% <0.00%> (+11.11%) 12.00% <0.00%> (+2.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a132a37...02c29ad. Read the comment docs.

mhaack commented 4 years ago

Verified