adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1241 - Pagination issue in product console column view #94

Closed LSantha closed 4 years ago

LSantha commented 4 years ago

Description

Product consoles loads product children of a category node very slow when there are a large number of product in a category. This PR addresses this issue by adjusting the limit and size parameters for product console column view by overlaying the column view provided by the core commerce content package.

Related Issue

CIF-1241

How Has This Been Tested?

Manually.

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #94 into master will increase coverage by 29.14%. The diff coverage is 95.23%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #94       +/-   ##
=============================================
+ Coverage     58.07%   87.22%   +29.14%     
- Complexity      239      394      +155     
=============================================
  Files            29       29               
  Lines          1579     1581        +2     
  Branches        226      227        +1     
=============================================
+ Hits            917     1379      +462     
+ Misses          519       98      -421     
+ Partials        143      104       -39
Flag Coverage Δ Complexity Δ
#integration 54.75% <38.09%> (+0.34%) 240 <1> (+1) :arrow_up:
#karma 92.71% <ø> (ø) 0 <ø> (ø) :arrow_down:
#unittests 82.72% <95.23%> (?) 377 <3> (?)
Impacted Files Coverage Δ Complexity Δ
...ifproductfield/impl/ChildrenDataSourceServlet.java 95% <100%> (+89.11%) 20 <0> (+16) :arrow_up:
...graphql/resource/GraphqlQueryLanguageProvider.java 80% <100%> (+23.24%) 24 <3> (+12) :arrow_up:
...cq/commerce/graphql/resource/CategoryResource.java 83.33% <66.66%> (+2.38%) 7 <0> (+2) :arrow_up:
...erce/graphql/resource/GraphqlResourceProvider.java 87.5% <0%> (+6.25%) 12% <0%> (ø) :arrow_down:
...rce/graphql/resource/CategoryProductsIterator.java 96.29% <0%> (+11.11%) 12% <0%> (+2%) :arrow_up:
...a/impl/CatalogDataResourceProviderManagerImpl.java 77.29% <0%> (+12.43%) 36% <0%> (+8%) :arrow_up:
...e/cq/commerce/graphql/resource/ResourceMapper.java 77.09% <0%> (+14.52%) 37% <0%> (+13%) :arrow_up:
...ommerce/graphql/resource/RootCategoryResource.java 95% <0%> (+15%) 9% <0%> (+2%) :arrow_up:
.../cq/commerce/graphql/resource/ProductResource.java 90% <0%> (+15%) 16% <0%> (+6%) :arrow_up:
...mmerce/graphql/core/GraphqlProductViewHandler.java 77.94% <0%> (+16.17%) 14% <0%> (+4%) :arrow_up:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17e4833...8ed63e4. Read the comment docs.