adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1243 - Pagination issue in product picker column view #96

Closed LSantha closed 4 years ago

LSantha commented 4 years ago

Description

Related Issue

CIF-1243

How Has This Been Tested?

Manually.

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #96 into master will decrease coverage by 0.24%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
- Coverage     87.46%   87.22%   -0.25%     
- Complexity      392      394       +2     
============================================
  Files            29       29              
  Lines          1580     1581       +1     
  Branches        227      227              
============================================
- Hits           1382     1379       -3     
- Misses           93       98       +5     
+ Partials        105      104       -1
Flag Coverage Δ Complexity Δ
#integration 2.37% <0%> (-56.99%) 11 <0> (-23)
#karma 92.71% <ø> (-3.32%) 0 <ø> (ø)
#unittests 82.72% <100%> (+0.08%) 377 <3> (+2) :arrow_up:
Impacted Files Coverage Δ Complexity Δ
...graphql/resource/GraphqlQueryLanguageProvider.java 80% <100%> (+1.62%) 24 <3> (+2) :arrow_up:
...atalog/admin/impl/CatalogIdentifierDatasource.java 100% <0%> (ø) 12% <0%> (ø) :arrow_down:
...omponents/common/cifpicker/clientlibs/cifpicker.js 80% <0%> (-11.12%) 0% <0%> (ø)
...a/impl/CatalogDataResourceProviderManagerImpl.java 77.29% <0%> (ø) 36% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de34c1e...16e1c16. Read the comment docs.

mhaack commented 4 years ago

Verified