adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1134 - Unified configuration of site settings #97

Closed dplaton closed 4 years ago

dplaton commented 4 years ago

Description

This is quite a big PR due to the fact that it contains both the UI implementation and the updates to the connector code.

Changes in the connector code:

The configuration UI:

Related Issue

CIF-1201 - Implement the configuration wizard CIF-1204 - Update the connector to use context-aware configurations

Motivation and Context

Unify configuration of the CIF Connector and CIF Core Components

How Has This Been Tested?

Intensive functional testing. Unit tests for the Sling Models are WIP

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #97 into master will increase coverage by 0.22%. The diff coverage is 82.03%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #97      +/-   ##
============================================
+ Coverage     87.14%   87.37%   +0.22%     
- Complexity      407      438      +31     
============================================
  Files            29       32       +3     
  Lines          1642     1734      +92     
  Branches        236      255      +19     
============================================
+ Hits           1431     1515      +84     
+ Misses          102      101       -1     
- Partials        109      118       +9
Flag Coverage Δ Complexity Δ
#integration 52.3% <43.75%> (-1.09%) 247 <11> (+4)
#karma 92.71% <ø> (ø) 0 <ø> (ø) :arrow_down:
#unittests 83.38% <81.25%> (+0.48%) 422 <43> (+31) :arrow_up:
Impacted Files Coverage Δ Complexity Δ
...graphql/resource/GraphqlQueryLanguageProvider.java 80% <100%> (ø) 27 <2> (ø) :arrow_down:
...e/cq/commerce/graphql/resource/ResourceMapper.java 77.09% <100%> (+1.67%) 37 <0> (+2) :arrow_up:
...erce/graphql/resource/GraphqlResourceProvider.java 87.5% <100%> (ø) 12 <1> (ø) :arrow_down:
...be/cq/commerce/virtual/catalog/data/Constants.java 100% <100%> (ø) 1 <1> (?)
...ents/configuration/ConfigurationColumnPreview.java 59.09% <59.09%> (ø) 6 <6> (?)
...nts/configuration/ConfigurationColumnViewItem.java 71.42% <71.42%> (ø) 12 <12> (?)
...a/impl/CatalogDataResourceProviderManagerImpl.java 81.81% <84.44%> (+4.52%) 43 <15> (+7) :arrow_up:
...aphql/resource/GraphqlResourceProviderFactory.java 97.95% <95.83%> (+0.98%) 12 <6> (+3) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 437795a...adcb79b. Read the comment docs.

herzog31 commented 4 years ago

@dplaton Please also add some documentation of all the changes. Like how do new customers configure the service and how do existing customers migrate.