CIF-1245 - Connector fails if Magento GraphQL response has errors.

[LSantha]

• propagate exception to childcolumnitem for error reporting

Description

The user needs some error reporting in the console if the product tree binding doesn't load products due to internal error. The node having the error is highlighted with a Granite alert.

Related Issue

CIF-1245

How Has This Been Tested?

Manually.

Screenshots (if appropriate):

Server side error reporting:

Client side error reporting

Types of changes

• [X] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] I have signed the Adobe Open Source CLA.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [X] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes and the overall coverage did not decrease.
• [X] All unit tests pass on CircleCi.
• [X] I ran all tests locally and they pass.

[codecov[bot]]

Codecov Report

Merging #98 into master will increase coverage by 0.19%. The diff coverage is 87.87%.

@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
+ Coverage     87.45%   87.65%   +0.19%     
- Complexity      454      460       +6     
============================================
  Files            33       34       +1     
  Lines          1794     1822      +28     
  Branches        272      277       +5     
============================================
+ Hits           1569     1597      +28     
+ Misses          102       99       -3     
- Partials        123      126       +3     

Flag	Coverage Δ	Complexity Δ
#integration	49.85% <12.12%> (-0.85%)	250.00 <6.00> (+1.00)	:arrow_down:
#karma	92.71% <ø> (ø)	0.00 <ø> (ø)
#unittests	83.90% <87.87%> (+0.27%)	444.00 <13.00> (+6.00)

Impacted Files	Coverage Δ	Complexity Δ
.../adobe/cq/commerce/graphql/resource/Constants.java	0.00% <ø> (ø)	0.00 <0.00> (ø)
...e/cq/commerce/graphql/resource/ResourceMapper.java	79.47% <87.50%> (+2.37%)	40.00 <10.00> (+3.00)
...be/cq/commerce/graphql/resource/ErrorResource.java	88.23% <88.23%> (ø)	3.00 <3.00> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5ee213...72c7ff0. Read the comment docs.

[mhaack]

Did not check the code yet :-) but only the screenshot we need to talk about the implementation. I don't think this way of display an error as a column item is the right way to do it. There are error & notification elements in the UI framework. Also, how will this look like in card or list view?

[LSantha]

@mhaack , I've added screenshots for list and card view too. I agree this is quite unusual, I'm actually using a resource to communicate the error to the client this is because throwing and exception from the Resource API implementation is not something that all the possible receiving components can handle properly and the result is that the console gets broken in various situations. The error message is displayed using alert available in Granite. We can still discuss it, and think about alternatives, I'm OK with that.