adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1247 - Product Picker bug #99

Closed LSantha closed 4 years ago

LSantha commented 4 years ago

Description

Product picker didn't return product slug because the slug was missing from the underlying product resource and related GaphQL query.

Related Issue

CIF-1247

How Has This Been Tested?

Manually, unit test.

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #99 into master will increase coverage by 2.66%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #99      +/-   ##
============================================
+ Coverage     84.56%   87.23%   +2.66%     
- Complexity      385      394       +9     
============================================
  Files            29       29              
  Lines          1581     1582       +1     
  Branches        227      227              
============================================
+ Hits           1337     1380      +43     
+ Misses          138       98      -40     
+ Partials        106      104       -2
Flag Coverage Δ Complexity Δ
#integration 54.78% <100%> (+52.72%) 240 <0> (+232) :arrow_up:
#karma 92.71% <ø> (ø) 0 <ø> (ø) :arrow_down:
#unittests 82.73% <100%> (+0.01%) 377 <0> (ø) :arrow_down:
Impacted Files Coverage Δ Complexity Δ
...be/cq/commerce/graphql/magento/GraphqlQueries.java 97.77% <100%> (+0.05%) 17 <0> (ø) :arrow_down:
...mmerce/graphql/magento/GraphqlDataServiceImpl.java 95.62% <0%> (+0.72%) 55% <0%> (+1%) :arrow_up:
...e/cq/commerce/graphql/resource/ResourceMapper.java 77.09% <0%> (+1.67%) 37% <0%> (ø) :arrow_down:
...graphql/resource/GraphqlQueryLanguageProvider.java 80% <0%> (+2.66%) 24% <0%> (+1%) :arrow_up:
...a/impl/CatalogDataResourceProviderManagerImpl.java 77.29% <0%> (ø) 36% <0%> (ø) :arrow_down:
...mnisearch/ProductsSuggestionOmniSearchHandler.java 88.76% <0%> (+3.37%) 13% <0%> (+1%) :arrow_up:
.../cq/commerce/graphql/resource/ProductResource.java 90% <0%> (+5%) 16% <0%> (+1%) :arrow_up:
...aphql/resource/GraphqlResourceProviderFactory.java 96.96% <0%> (+6.06%) 9% <0%> (+1%) :arrow_up:
...erce/graphql/resource/GraphqlResourceProvider.java 87.5% <0%> (+6.25%) 12% <0%> (+1%) :arrow_up:
...e/renderconditions/IsProductDetailPageServlet.java 93.54% <0%> (+6.45%) 11% <0%> (+1%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11ab539...fc67e7a. Read the comment docs.

mhaack commented 4 years ago

Verified