search

adomokos / light-service

Series of Actions with an emphasis on simplicity.
MIT License
837 stars 67 forks source link

Orchestrator not raising failing context #128

Closed redjoker011 closed 6 years ago

redjoker011 commented 6 years ago

Hi i just want to ask why orchestrator does not raise failing context unlike organizers? is this intended or is there another way to identify whenever an organizer/action fails when executing steps in orhcestrator?

adomokos commented 6 years ago

Could you please provide an example? A failing spec would be the best.

Just an FYI, I am planning on removing Orchestrators from LightService and adding all Orchestrator functionality to Organizers.

redjoker011 commented 6 years ago

The issue that i've facing is when you mix actions and organizers inside orchestrator steps, orchestrator only catch failing actions but when failing actions are inside organizers, orchestrator does not catch failing context which results the orchestrator to success even with failing context. Also orchestrator only return response from actions but response from organizers are missing. Am i the one experiencing this issue? Thanks for response

adomokos commented 6 years ago

@redjoker011: I added a spec to prove the functionality of failed context from an Organizer in an Orchestrator spec in PR #131.

Can you please alter the code I started to show where the failure is not bubbling up?

adomokos commented 6 years ago

@redjoker011 - is this still an issue?

redjoker011 commented 6 years ago

Yeah the issue still persist so i decided to use Organizer instead. Also since you've mention that you would remove Orchestartors in future , maybe we can close this issue since it is Orchestartor related. Thanks for the time

adomokos commented 6 years ago

K, I'll close it for now. 0.9.0 will be released very soon, I am testing it with our apps.