Require AS deprecation, that way we can upgrade to AS 5

adomokos / light-service

Series of Actions with an emphasis on simplicity.

MIT License

837 stars 67 forks source link

Require AS deprecation, that way we can upgrade to AS 5 #89

Closed adomokos closed 8 years ago

adomokos commented 8 years ago

I suspect auto-require of AS deprecation has been removed from the project, even Rails requires it in files it is using it.

Closes #86

jeroenvisser101 commented 8 years ago

Just one thought, we're now mixing single and double quotes, any rule here?

adomokos commented 8 years ago

Good point, I would have expected Rubocop warning about that. All the requires in lib/light_service.rb are using single quotes, I just followed that.

We should be using double quotes only when string interpolation is needed. I'll see how I could tweak Rubocop to warn about that. Thanks!