adonisjs / v6-docs

Documentation website for AdonisJS v6
38 stars 53 forks source link

fix: fake mailer assert methods #125

Closed memsbdm closed 1 day ago

RomainLanz commented 1 week ago

Could you please explain your changes?

memsbdm commented 5 days ago

@RomainLanz previous methods used in docs (assertHasTo, assertHasFrom, ..) doesn't exist anymore. It should be / was replaced by assertTo, assertFrom, ...

Also these methods are not returning this anymore so we cannot chain them so I removed that part from the first example.

RomainLanz commented 5 days ago

Cool! I wonder if it wouldn't be better to add back the "chainability" of those assertions.

Let's see what @Julien-R44 or @thetutlage think.

thetutlage commented 1 day ago

The PR for docs matches the implementation. We can discuss about chaining of methods separately 🙂

thetutlage commented 1 day ago

Thanks @memsbdm