adonisjs / v6-docs

Documentation website for AdonisJS v6
38 stars 53 forks source link

incomplete url fix for markdown links with _ to join .md name in ace … #93

Closed HughBerriez closed 1 month ago

HughBerriez commented 1 month ago

Hello!

I was getting up to speed via the seamlessly crafted adonis6 docs. In the Ace section, a number of the hyperlinks weren't working. I noticed that the url was going back one additional folder level ../ than needed. Upon removing the 3 instances I found of this in the above PR, the hyperlinks link correctly to the corresponding .md files within the repo itself. The open problem left though that I was unable to figure out was that once one runs npm run dev, the url has an _ instead of a- to concatenate the two worded url. For example: https://docs.adonisjs.com/guides/testing/console_tests is now the route and should be https://docs.adonisjs.com/guides/testing/console-tests. Any thoughts on how I can help fix this? Thank you again Adonis team for such an awesome product!

Best, Hugh B.

thetutlage commented 1 month ago

Fixed in https://github.com/adonisjs/v6-docs/commit/d87a097d96194e281cd3d62c710a4931573ee2d7