adoptium / infrastructure

This repo contains all information about machine maintenance.
Apache License 2.0
84 stars 100 forks source link

UnixPB: Add tags to tasks in Common role #3580

Open aswinkr77 opened 4 weeks ago

aswinkr77 commented 4 weeks ago

Added tags to sub folder tasks in Common role, such that these tags can be used to run/skip the respective tasks.

Checklist
sxa commented 4 weeks ago

I've started running the VPC checks (link in description) This PR is in reference to the thread at https://adoptium.slack.com/archives/C53GHCXL4/p1716809812153839 where the user was unable to run the playbooks with -t patch_update to initiate that part of the Common role

karianna commented 4 weeks ago

@aswinkr77 Seems to be a number of CI failures, not sure if related...

aswinkr77 commented 4 weeks ago

@karianna it's related I think. The task - name: Perform OS setup and configuration contains the adoptopenjdk tag which is used as the skip tag, so the task is getting skipped.

aswinkr77 commented 4 weeks ago

I think I'll remove all the unnecessary tags and add only the necessary tags we need in the main.yml file.

aswinkr77 commented 3 weeks ago

This solution is not viable at the moment. I'll add the missing tags to the tasks and stick with skipping tags instead of running the tags.

aswinkr77 commented 1 week ago

@sxa I've changed the approach. Since the VPC checks were failing - related to the newly(previously) added tags in the main.yml file. Now I've removed it, and added tags to almost all tasks in all sub folder tasks in Common role. So these tags can be used to skip unnecessary tasks.