adoptium / infrastructure

This repo contains all information about machine maintenance.
Apache License 2.0
84 stars 100 forks source link

docker: Add ubi9 docker static dockerfile #3592

Closed Haroon-Khel closed 2 weeks ago

Haroon-Khel commented 2 weeks ago

ref https://github.com/adoptium/infrastructure/issues/3586

sxa commented 2 weeks ago

Also can we change the commit message to indicate that this is a static dockerfile to distinguish it from a build one please?

sxa commented 2 weeks ago

Noting also that the UBI8 file (which this ubi9 one is based on) also has similar "features" to the ones mentioned in my review.

@steelhead31 Do you recall why libnss3.so was passed to yum in this dockerfile? (Ref: https://github.com/adoptium/infrastructure/pull/3169) It looks like that doesn't work on UBI8 either - it's also in the playbooks for RPM-based distributions, although I haven't yet found any it'll work on on aarch64.

steelhead31 commented 2 weeks ago

Noting also that the UBI8 file (which this ubi9 one is based on) also has similar "features" to the ones mentioned in my review.

@steelhead31 Do you recall why libnss3.so was passed to yum in this dockerfile? (Ref: #3169) It looks like that doesn't work on UBI8 either - it's also in the playbooks for RPM-based distributions, although I haven't yet found any it'll work on on aarch64.

Nope, I can't recall , it will have been something to do with a missing dependency or build from source of some kind, but its possibly redundant now. Id say remove it , and see if we encounter any other issues as a reminder.