search

adoptium / infrastructure

This repo contains all information about machine maintenance.
Apache License 2.0
84 stars 100 forks source link

WinPB: Update GPG Verification Process For Ant Binary #3639

Closed steelhead31 closed 1 day ago

steelhead31 commented 3 days ago

Fixes #3638

Checklist

VPC OK: https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=Win2022,label=vagrant/1895/console

Fails on wix installation, which is fixed in this PR, which will be rebased with these changes:

https://github.com/adoptium/infrastructure/pull/3628

steelhead31 commented 2 days ago

I'd like to just question the range of code within the disable/re-enable of the gpgagent and dirmgr 'block'.

  1. Excuse my ignorance - is there a way to wrap the code in a structure that will be assured to be run if the commands within the 'block' fail, so that a failure case doesn't leave the state disabled?

I've updated the code, so that it will always run the chmod to restore the permissions

  1. Can you assure that all commands in the 'block' require the state to be disabled, just so we know we have minimised all commands running in the 'block'.

I've reduced the scope of the disablement to just be disabled for the import of the gpg key, as this is the step that causes issues by spawning unwanted subprocesses, that hang execution.