adoptium / infrastructure

This repo contains all information about machine maintenance.
Apache License 2.0
86 stars 102 forks source link

Add conditionals for Rhel9 in common role #3802

Open AswathySK opened 2 weeks ago

AswathySK commented 2 weeks ago

The common role for Unix playbook doesnt include conditionals for rhel9 causing playbook failures.

Failures caused due to current condition:

Checklist
AswathySK commented 2 weeks ago

@AdamBrousseau instead of changing conditional to do it for everything greater than or equal to rhel 8 instead? There could be change in package dependencies for the future releases. So how to make the change right now is up to the community I suppose.

AdamBrousseau commented 2 weeks ago

Sure. We can get other opinions. If we change it to be something like >=, and it stops working, the PBs will presumably fail and someone can investigate at that point. That would have to happen either way, but at least this way, you don't have to monitor and update it when it works.

AdamBrousseau commented 1 week ago

@sxa do you have an opinion on the above?

AswathySK commented 1 week ago

@AdamBrousseau , I have made the change as per your suggestion.