search

adoptium / infrastructure

This repo contains all information about machine maintenance.
Apache License 2.0
86 stars 101 forks source link

Remove redundant Alpine JDK installs #3804

Open Haroon-Khel opened 9 hours ago

Haroon-Khel commented 9 hours ago

Looks like we're installing boot jdks on Alpine using two different roles in our playbooks

In the common role (zulu bianries and nightlies) https://github.com/adoptium/infrastructure/blob/master/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/tasks/Alpine.yml

and in the adoptopenjdk_install role (only for jdk17 and 21) https://github.com/adoptium/infrastructure/blob/master/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/adoptopenjdk_install/tasks/main.yml

I propose we use the adoptopenjdk_install to install bootjdks and not the common role, as we do with our other platforms. I assume we used the common role to install zulu binaries because there was no other option, so I reckon if these can now be replaced with our own binaries

Haroon-Khel commented 9 hours ago

https://github.com/adoptium/infrastructure/pull/3805 in to stop the adoptopenjdk_install role from installing a non existent GA JDK17 on aarch64 alpine linux