adrianmichel / yloader

Free stock quotes downloader
http://www.yloader.com
42 stars 19 forks source link

not downloding #22

Open amiralshoq opened 6 months ago

amiralshoq commented 6 months ago

I Have problem (HTTP response error429) as pix

3

peter-lernyx commented 6 months ago

+1

pstenson commented 6 months ago

+1

ZeroAssoluto996 commented 6 months ago

MeToo

VitaliPP commented 6 months ago

MeToo

Rahmengo commented 5 months ago

I am having the same issue. Am getting a "HTTP response error429" message when attempting to download

pinotin commented 5 months ago

I have the exact same problem and I have already reported it. Solution?

peter-lernyx commented 5 months ago

It can take a minute for the author to attend to this. We had a similar issue due to Yahoo changes a year or two ago and Adrian did eventually fix it. But this is a free piece of software guys, nobody is paying him a dime, so please be realistic in your expectations. In the meantime, you can use InvestExcel multiple stock downloader spreadsheet to get automated bulk downloads from Yahoo. It is nowhere near as convenient as Yloader but at least it works. Description: https://investexcel.net/multiple-stock-quote-downloader-for-excel/

Sheet download: https://investexcel.net/wp-content/uploads/2013/01/Multiple-Stock-Quote-Downloader-2nd-May-2022.zip

enkynakamura commented 5 months ago

I encountered the same issue today. I even reduced to just one concurrent connection at a time, but I still got HTTP 429 errors.

Sleepy-Snake commented 5 months ago

Has anyone figured out what Yahoo has changed to cause yhe problem yet?

Rahmengo commented 5 months ago

As of 2024-06-13 I am still getting the HTTP response error429. Would be great if someone can point me in the right direction on how to fix this and I will give it a try myself.

Rahmengo commented 5 months ago

I am still having the same problem

adilpr commented 5 months ago

I am still having the same problem

https://stackoverflow.com/questions/78111453/yahoo-finance-api-file-get-contents-429-too-many-requests

BoulderLou commented 5 months ago

A quick attempt to add a USER_AGENT to determine if it actually fixes the issue.

in httprequest.cpp change this line: handleCurlResult(curl_easy_setopt(m_curl, CURLOPT_USERAGENT, userAgent.c_str()), "curl_easy_setopt( CURLOPT_USERAGENT )");

to this: handleCurlResult(curl_easy_setopt(m_curl, CURLOPT_USERAGENT, "Mozilla/4.0;"), "curl_easy_setopt( CURLOPT_USERAGENT )");

and it now downloads the Yahoo data. Screenshot 2024-06-22 095834

I'll need to go back to make the proper modifications in the HTTPRequestBase class.

adilpr commented 5 months ago

A quick attempt to add a USER_AGENT to determine if it actually fixes the issue.

in httprequest.h change this line: handleCurlResult(curl_easy_setopt(m_curl, CURLOPT_USERAGENT, userAgent.c_str()), "curl_easy_setopt( CURLOPT_USERAGENT )");

to this: handleCurlResult(curl_easy_setopt(m_curl, CURLOPT_USERAGENT, "Mozilla/4.0;"), "curl_easy_setopt( CURLOPT_USERAGENT )");

and it now downloads the Yahoo data. Screenshot 2024-06-22 095834

I'll need to go back to make the proper modifications in the HTTPRequestBase class.

Can you share with us a link of the working file. Thanks.

Also, a request in yloader settings -- data sources - can you please add "initial delay between requests (milliseconds) ... and user could, for example input, 1000. this would reduce load on yahoo servers. If you need further inputs from my end let me know. Thanks.

BoulderLou commented 5 months ago

The executable files for the temporary fix are located in the link below along with some others that you will not need, like an old log file from the Release/x64 directory.

Built with Visual Studio 2019 Release/x64 directory https://github.com/BoulderLou/YloaderTmpFix20240622.git

adilpr commented 5 months ago

A humble thanks. i would like you to add the personalised feature i requested earlier about inital delay between requests...

BoulderLou commented 5 months ago

Sorry, but you are not likely to get any "personalized" UI modifications from me anytime soon. I would leave that up to the original developer, Adrian or anyone else who would enjoy modifying the source code.

When Yloader stopped working, I modified the InvestExcel multiple stock downloader Excel spreadsheet to suit my needs, until I had the time to dig into the Yloader code.

toddao commented 5 months ago

thank you much BoulderLou, works.

On Sat, 22 Jun 2024 11:18:08 -0700, you wrote:

The executable files for the temporary fix are located in the link below along with some others that you will not need, like an old log file from the Release/x64 directory.

Built with Visual Studio 2019 Release/x64 directory https://github.com/BoulderLou/YloaderTmpFix20240622.git

adilpr commented 5 months ago

yahooplugin.zip

Hi BoulderLou, I have attatched yahooplugin.cpp. i donot know how to generate yahooplugin.ypi file. if possible pls send as attatchment (.zip).. i have on line 75 kept sleep(1000) to slow download. Thanks.

pinotin commented 5 months ago

I downloaded the files and inserted them into the Jdownloader program folder. Now it no longer gives an error but does not download all the requested data as per the attached image. Thank you Error

BoulderLou commented 5 months ago

I downloaded the files and inserted them into the Jdownloader program folder. Now it no longer gives an error but does not download all the requested data as per the attached image. Thank you Error


I tried a few of your symbols and it downloads the data for me. The downloaded data agrees with the raw data from Yahoo.

YloaderItaly Yloader_amb_data

YahooAMB

BoulderLou commented 5 months ago

I downloaded the files and inserted them into the Jdownloader program folder. Now it no longer gives an error but does not download all the requested data as per the attached image. Thank you Error


Perhaps you need to check your validation settings: YloaderValidationSettings

pstenson commented 5 months ago

The executable files for the temporary fix are located in the link below along with some others that you will not need, like an old log file from the Release/x64 directory.

Thank you for the "temp fix", it works just fine. YLoader is a lot easier to use than my temp fix of cutting and pasting from Google sheets.

BoulderLou commented 5 months ago

yahooplugin.zip

Hi BoulderLou, I have attatched yahooplugin.cpp. i donot know how to generate yahooplugin.ypi file. if possible pls send as attatchment (.zip).. i have on line 75 kept sleep(1000) to slow download. Thanks.


Not sure why you want to slow things down but... placing the sleep statement in that location would not work and most likely generate build errors.

Have you tried limiting the "simultaneous connections" to 1? YloaderSlowDown

toddao commented 5 months ago

I downloaded everything in BoulderLou.s subdirectory without knowing what was what and put it in my yloader subdirectory, overwriting everything. It worked.

https://github.com/BoulderLou/YloaderTmpFix20240622/tree/main/Release/x64

On Sun, 23 Jun 2024 14:50:22 -0700, you wrote:

yahooplugin.zip

Hi BoulderLou, I have attatched yahooplugin.cpp. i donot know how to generate yahooplugin.ypi file. if possible pls send as attatchment (.zip).. i have on line 75 kept sleep(1000) to slow download. Thanks.


Not sure why you want to slow things down but... placing the sleep statement in that location would not work and most likely generate build errors.

Have you tried limiting the "simultaneous connections" to 1? YloaderSlowDown

adilpr commented 5 months ago

Thank you BoulderLou and toddao.

adilpr commented 5 months ago

image

Hi, any thoughts on why all symbol status is ignored..

Interesting to know yloadercl.exe works perfectly...

BoulderLou commented 5 months ago

image

Hi, any thoughts on why all symbol status is ignored..

Interesting to know yloadercl.exe works perfectly... @@@@@@@@@@@@@@@@@@@@@@@@@@@@@

Nvidia is not a symbol. It is the company name. NVDA is the correct symbol.

adilpr commented 5 months ago

image

image

BoulderLou commented 5 months ago

image

Hi, any thoughts on why all symbol status is ignored..

Interesting to know yloadercl.exe works perfectly...


Tried your symbols...they work for me. Perhaps something in your settings or file system

YloaderTestSyms

adilpr commented 5 months ago

image Hi, any thoughts on why all symbol status is ignored.. Interesting to know yloadercl.exe works perfectly...

Tried your symbols...they work for me. Perhaps something in your settings or file system

YloaderTestSyms

Hi BoulderLou, You are a genius. I deleted settings.ini. restarted yloader...problem solved. Thank you very much.

image

amiralshoq commented 5 months ago

HI ,BoulderLou

You are amazing thank you very much I just copied the files and replaced them

Kkorelli commented 5 months ago

Hi BoulderLou

Im really pleased that you have found a fix for Yloader, as it is a terrific program and has provided me with many years of use.

I’m assuming that I would just need to copy your files into the Program Directory folder where Yloader is kept and replace old duplicate files.

Just one question, my PC is 32 bit (x86 I believe); will your modified files still work?

Many thanks

BoulderLou commented 5 months ago

Hi BoulderLou

Im really pleased that you have found a fix for Yloader, as it is a terrific program and has provided me with many years of use.

I’m assuming that I would just need to copy your files into the Program Directory folder where Yloader is kept and replace old duplicate files.

Just one question, my PC is 32 bit (x86 I believe); will your modified files still work?

Many thanks


No, it won't work on a 32bit/x86 machine, as the build target is for a 64bit machine. That is why the directory is named "Release/ x64" I can build a 32bit version and upload it in the next few days.

BoulderLou commented 5 months ago

For those of you using 32-bit systems.... I uploaded a release build for 32-bit systems...

https://github.com/BoulderLou/YloaderTmpFix20240622/tree/main/x86

ZeroAssoluto996 commented 5 months ago

Thank you BoulderLou, very good job.

Kkorelli commented 5 months ago

Hi BoulderLou

Thanks for your speedy response.

To add to the comments of others, I am very grateful for your time and effort in extending the life of YLoader, especially for the older PC’s.

NorskTrader commented 5 months ago

Thank you for your repair of YLoader, BoulderLou.

I'm new here, so I apologize in advance for asking such basic questions.

But I see in the last seven hours you've uploaded some new files, including y6_64_setup.exe

Does that single file contain all the fixes you'd previously uploaded as individual file subcomponents?

Or should I download each of the files you offered here: YLoaderTmpFix20240622/Release/x64

BoulderLou commented 5 months ago

Thank you for your repair of YLoader, BoulderLou.

I'm new here, so I apologize in advance for asking such basic questions.

But I see in the last seven hours you've uploaded some new files, including y6_64_setup.exe

Does that single file contain all the fixes you'd previously uploaded as individual file subcomponents?

Or should I download each of the files you offered here: YLoaderTmpFix20240622/Release/x64


The *setup.exe files are installers for the fix. I've made the appropriate modifications to the class structures instead of the one line quick fix. The directories have been removed, as they are no longer needed. For a 64-bit system, run the y6_64_setup.exe to install the latest modifications on your system.

Gtzs-888 commented 2 months ago

Is it down ?

amiralshoq commented 2 months ago

The executable files for the temporary fix are located in the link below along with some others that you will not need, like an old log file from the Release/x64 directory.

Built with Visual Studio 2019 Release/x64 directory https://github.com/BoulderLou/YloaderTmpFix20240622.git

Greetings to you, It was working well after you fixed it, but now it comes back and shows an error as in the picture. I am waiting for a response from you, my dear, and if it is possible for a brief explanation of how to fix the program’s errors in the future, I sincerely thank you in advance.

12

amiralshoq commented 2 months ago

It can take a minute for the author to attend to this. We had a similar issue due to Yahoo changes a year or two ago and Adrian did eventually fix it. But this is a free piece of software guys, nobody is paying him a dime, so please be realistic in your expectations. In the meantime, you can use InvestExcel multiple stock downloader spreadsheet to get automated bulk downloads from Yahoo. It is nowhere near as convenient as Yloader but at least it works. Description: https://investexcel.net/multiple-stock-quote-downloader-for-excel/

Sheet download: https://investexcel.net/wp-content/uploads/2013/01/Multiple-Stock-Quote-Downloader-2nd-May-2022.zip

Thanks, but unfortunately even this excel file does not work