search

adsabs / adsrex

Collection of functional tests for ADS Api and Bumblebee
MIT License
0 stars 6 forks source link

Feature/aws 187/adsws work in test cluster #6

Closed jonnybazookatone closed 8 years ago

jonnybazookatone commented 8 years ago

Changes were made such that mission-control could execute ADSRex to work on a test cluster. This PR contains the conversion of tests to utilise unittest classes, and some aesthetic changes. It's possible a lot of these changes may not be liked, so I have setup a branch called 'develop', such that the original branch is not touched if we do not want to merge them.

Future modifications for mission-control will be made on develop for the time being, in case someone wants to do a code review of the changes after our internal deadlines of 2015 end.

All the tests pass in the test environment, bar that of the orcid-service, which is noted in an open ticket #5.

This PR closes #4.

jonnybazookatone commented 8 years ago

I'll merge as it doesn't touch master, feel free to comment/make changes if necessary, and open a ticket if you have issues.

romanchyla commented 8 years ago

some people will use OOP in everything, some never, and some others only for certain classes of problems - these tests were initially simple curl checks; they didn't need to carry any state - and no tearDown/setUp is pprobably necessary

so: lot of time/energy was expended on turning them into OOP and I personally don't see such great benefits in it - I only hope the reasoning is not "because OOP is better" (that is just a fundamentalist view - and fundamentalists are 'never' right ;-))

jonnybazookatone commented 8 years ago

Nah, not much time or effort was spent in modifying them to be OOP, maybe 2 mins per test. I did it out of preference to make things easier for myself to ensure the tests worked in the test cluster in the way I find easier, and separated some tests to try to make them smaller and more verbose if something fails.

More time was spent getting the tests to pass for different reasons, and so the PR may appear like it took me a while, but not really.