search

adventuregamestudio / ags-manual

AGS documentation.
https://adventuregamestudio.github.io/ags-manual/
MIT License
26 stars 9 forks source link

GitHub Actions: Node.js 12 actions are deprecated #203

Closed ericoporto closed 1 year ago

ericoporto commented 1 year ago

A bunch of warnings are appearing in our GitHub Actions saying that we need to migrate to Node.js 16.

I believe the solution is basically switching all GH Actions from v2 to v3.

https://github.com/adventuregamestudio/ags-manual/blob/9a5720dceff98b42241b067225f55ef4a5f8075d/.github/workflows/build.yml#L37

https://github.com/adventuregamestudio/ags-manual/blob/9a5720dceff98b42241b067225f55ef4a5f8075d/.github/workflows/build.yml#L133

https://github.com/adventuregamestudio/ags-manual/blob/9a5720dceff98b42241b067225f55ef4a5f8075d/.github/workflows/build.yml#L140

https://github.com/adventuregamestudio/ags-manual/blob/9a5720dceff98b42241b067225f55ef4a5f8075d/.github/workflows/build.yml#L146

https://github.com/adventuregamestudio/ags-manual/blob/9a5720dceff98b42241b067225f55ef4a5f8075d/.github/workflows/build.yml#L171

It's necessary need to test in a fork if upgrading those fixes this warning, since we do use some Actions that are not from GitHub itself.

ericoporto commented 1 year ago

fixed by https://github.com/adventuregamestudio/ags-manual/commit/b8562fdf748cac00f2a4660433e1f1197065d830