Closed AlanDrake closed 1 year ago
Oh well... looks like I force pushed the fix to upstream due to a bad configuration... my apologies @morganwillcock
Well, it was technically already merged by mistake, but I'll keep this open for the discussion or further changes and then close it. Do we want numbered lines? I guess not because it may look bad on one liners, it can be enabled by adding a class to specific code blocks but I feel it's not worth the hassle.
I think I have colored all the styles that are actually used, the others I moved down the list, warn me if you ever spot them in the wild because without an example it's hard to style stuff.
Don't worry about the updating of the branch: as it is I think everything is readable. Just going by eye, I'd guess the contrast between the purple highlighting and the dark theme might be a little low, but I'm also not setup to make any kind of contrast assessment.
Do we want numbered lines?
I'd probably say no, as the number of lines in each block is normally quite low.
Bumped up the contrast
@morganwillcock Is the branch good for merging? Is there something else you have in mind to tackle there?
It is fine with me.
ok, I am working on my fork and will upstream the merge shortly
Closing this as it's already merged and approved
Give me feedback if this is good enough or if we should try other themes.