search

aecworks / aec.works-api

Backend for https://aec.works
GNU General Public License v3.0
5 stars 1 forks source link

Users cannot suggest edits #93

Closed m-clare closed 3 years ago

m-clare commented 3 years ago

Tried adding a new hashtag to an existing company and received the following error, despite this being my first attempted edit of an existing company:

'nonFieldError: non-editor user exceeded limit of unmoderated edits'

image
gtalarico commented 3 years ago

This is by design.

Currently users (non-editors) can have up to 1 unmoderated submissions. Once it's approved you can submit more. You already have a pending one ('Toggle Industries')

Currently shows as an error. Maybe We should show a friendlier message or reconsider the process?

Maybe we can allow more, like 3-5?

https://github.com/aecworks/aec.works-api/blob/18037839d15b07e7f9cd8005591ade1ff11c5bcb/api/community/services.py#L168

gtalarico commented 3 years ago

And view: https://github.com/aecworks/aec.works-api/blob/master/api/community/views/company_revisions.py

I think we should increase to at least 2. I just didn't want to get flooded with reviews since we don't have many editors active yet

PR: https://github.com/aecworks/aec.works-api/pull/94