Closed darahayes closed 4 years ago
When offline logout will fail with dinosaur which is bad experience so @kingsleyzissou added a nice message there.
It will be cool to pass isOnline
but if that is a lot of work then-current solution is ok (we will need to remove dialog as well)
Okay good to know. Current solution is perfect then we were just forgetting to pass isOnline
in there. The actual functionality works perfectly!
update: I've added a fix here that enables keycloak with self signed certs
Looks good from my side
Description
isOnline
wasn't being passed down. It was always showing theyou are offline error
. It's not a big deal but do we even need to check that? You should be able to log out while offline IMO.Checklist
npm test
passesnpm run build
works