aerogear / datasync-starter

GraphQL Low Code React and Node.js DataSync Application template
http://graphback.dev
MIT License
32 stars 38 forks source link

DataSync 2.0 #420

Closed wtrocki closed 4 years ago

wtrocki commented 4 years ago

Purpose of this branch is to bring latest and greatest features from Graphback and Offix.

wtrocki commented 4 years ago

OVP showed us some problems with general user experience:

That is why I'm going to use this as a long-living branch to bring full features of graphback and measure impact on offix

wtrocki commented 4 years ago

@kingsleyzissou Quick opinion. Do we want to have TaskView screen that will allow add comments. I have done some preparation for this,

kingsleyzissou commented 4 years ago

@wtrocki, I think if it's not too much work and it's easy to maintain then we can go ahead with a TaskView

kingsleyzissou commented 4 years ago

@wtrocki the root query should be holding a reference to the normalised cache objects, is that correct?

And here it just looks like it’s duplicating them in both places. Have I understood correctly?

wtrocki commented 4 years ago

Requires custom offix: aerogear/offix#504

wtrocki commented 4 years ago

I have updated offix to make this work.

@kingsleyzissou would you have time to play with this branch in context of the: https://github.com/aerogear/offix/issues/499

Some things might require some quick fixes still (I do not have much time to get that done now) but it looks we can somehow patch offix to work with latest graphback and unblock release while still keeping the work on the datastore.

Any feedback is greatly appreciated.

What is outstanding here:

kingsleyzissou commented 4 years ago

Okay leave the outstanding stuff, I will have a look at that and try get that sorted.

Just busy testing the updates on the sample app and then I'll come around to this.

kingsleyzissou commented 4 years ago

https://github.com/aerogear/datasync-starter/issues/435

kingsleyzissou commented 4 years ago

https://github.com/aerogear/datasync-starter/issues/436

wtrocki commented 4 years ago

I think it will be easier for us to merge this to master with alpha release after we know that keycloak works (@kingsleyzissou since you have been doing keycloak before can you try this with keycloak as well).

If we merge then we can add incremental changes and proper graphback release once it happens. In the meantime this will close offix 1.5 work and we could fully leave this repository for the moment till we have some alpha releases of Offix 2.0.

@kingsleyzissou Does this make sense?

Ping me for quick review of the client once you are happy with this :D

kingsleyzissou commented 4 years ago

@wtrocki sure I will review the keycloak stuff. I will try find a quick win for the optimistic responses, I think the Offix 2.0 stuff should take priority.

Will ping you as soon as it's ready

kingsleyzissou commented 4 years ago

@wtrocki I have updated those small changes.

Doesn't look like the keycloak role stuff is working properly. But will try debug that on Monday morning.

Have a good weekend.

wtrocki commented 4 years ago

This is ready to be merged. However some clarification and verification of the walkthrough will be needed. CC @mmusil