search

aertslab / AUCell

AUCell: score single cells with gene regulatory networks
110 stars 26 forks source link

Mistake in "outlierOfGlobal" calculation in priv_auc.assignmnetThreshold_v6.R #17

Closed alexander-7 closed 2 years ago

alexander-7 commented 3 years ago

If the AUC thresholds follow a normal distribution (maybeNormalDistr returns TRUE) the threshold is calculated as outliers of the global distrubtion according to the thrP value set by the user. However, the current formula is not given the expected results, since thrP is divided by nCells (see line below). Instead it should be qnorm(1-thrp,mean=meanAUC, sd=sdAUC), or am I mistaken?

aucThrs["outlierOfGlobal"] <- qnorm(1-(thrP/nCells), mean=meanAUC, sd=sdAUC)

alexander-7 commented 3 years ago

Could be solved by merging #18