search

aewallin / allantools

Allan deviation and related time & frequency statistics library in Python
GNU Lesser General Public License v3.0
222 stars 76 forks source link

Fix usage of deprecated scipy.integrate function #159

Closed aidanmontare-fed closed 6 months ago

aidanmontare-fed commented 6 months ago

switch from scipy.integrate.simps to scipy.integrate.simpson

scipy.integrate.simps was deprecated in scipy 1.12.0 and will be removed in 1.14 (the upcoming minor version number).

https://docs.scipy.org/doc/scipy/release/1.12.0-notes.html#deprecated-features

This does introduce a requirement of scipy>=1.6.0, which is when scipy.integrate.simpson was introduced

https://docs.scipy.org/doc/scipy/release/1.6.0-notes.html#scipy-integrate-improvements

We could use a conditional import if we want compatability with older versions?

coveralls commented 6 months ago

Coverage Status

coverage: 89.396% (-2.7%) from 92.13% when pulling bb5555799d1b4351013f6e96f9b7881e1b7996c6 on aidanmontare-fed:fix-deprecated-simpson into 8faefa93fc810a1e73cce6dc50d5c80b7ca7599d on aewallin:master.

aewallin commented 6 months ago

scipy 1.6.0 release date seems to be around 2020? I guess the >=1.6.0 requirement doesn't affect that many users..