search

aewallin / allantools

Allan deviation and related time & frequency statistics library in Python
GNU Lesser General Public License v3.0
226 stars 77 forks source link

Why is the length of violet noise samples-1? #74

Closed jondoesntgit closed 5 years ago

jondoesntgit commented 6 years ago

It's easy enough to correct on my end, but it seems inconsistent.

https://github.com/aewallin/allantools/blob/master/tests/functional_tests/test_noise.py

aewallin commented 6 years ago

Looks like diff( random(num_points) ) could be changed to diff( random(num_points+1) ) over here https://github.com/aewallin/allantools/blob/master/allantools/noise.py#L71

I agree that for consistency all noise-functions should return the same number of points. Another questions is if we want to keep all the individual noise-generators or use Kasdin&Walter for everything?