afcapel / stimulus-autocomplete

Stimulus autocomplete component
MIT License
478 stars 61 forks source link

data-autocomplete-query-param-value not working #128

Closed kg-currenxie closed 1 year ago

kg-currenxie commented 1 year ago
<div data-controller="autocomplete" data-autocomplete-url-value="/search" data-autocomplete-query-param-value="query" role="combobox">

still gives me ?q= in the url

pin 'stimulus-autocomplete', to: 'https://ga.jspm.io/npm:stimulus-autocomplete@3.0.2/src/autocomplete.js'
pin '@hotwired/stimulus', to: 'https://ga.jspm.io/npm:@hotwired/stimulus@3.2.1/dist/stimulus.js'
robinaugh commented 1 year ago

@kg-currenxie I ran into this issue too - it looks like the latest release does not yet include this functionality, but changing my package.json to point at the current SHA of the main branch (and then yarn installing) did the trick:

git+https://github.com/afcapel/stimulus-autocomplete.git#7c22de1eff4b1028ea4918db60c63f6b30f04b8c
kg-currenxie commented 1 year ago

I see, thanks :D Hope it gets released soon

ACPK commented 1 year ago

Duplicate of https://github.com/afcapel/stimulus-autocomplete/issues/128

afcapel commented 1 year ago

I've just published a new release that includes this feature.