aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
655 stars 203 forks source link

Use different color for the default, mixin and user properites #186

Closed fernandojsg closed 5 years ago

fernandojsg commented 8 years ago

I was thinking about using subtle differences in the color of the label of each property depending if they're the default value, a custom modified value by the user, or if that value is inherit from a mixin. Any ideas?

dmarcos commented 8 years ago

Colors are fine to tell you there's something different about the property but they're not very useful to remember exactly why. Can you rember the colors used by your IDE to hightlight your code?

I don't knoe if there's a way to also label the properties with text without adding too much clutter

fernandojsg commented 8 years ago

I believe that just for modified values it will be easy to understand and to learn that as soon as you modified one value it will change the color. The problem come with the mixins, because you could maybe add some extra info, an icon, a cursive, whatever but then you could have a mixin inherit value but that you also modified after, so what to do in these cases.

ngokevin commented 8 years ago

I don't think color is the solution. Something like the Computed Styles would work better, but don't think it's too important for now.

screen shot 2016-07-11 at 12 49 05 pm
dmarcos commented 8 years ago

I would start just differentiating the color of default vs user modified values. It is the most bang for the buck. It's useful as a learning tool to answer questions like: How can achieve this cool effect with the material? You can look at the attribute and at a glance see the tweaked values that make that effect.

fernandojsg commented 8 years ago

Right now in the "title" tooltip when you've your mouse over the attribute's name, you get:

depth:
 - type: 'int'
 - value: 0.3

I'll add also default: 1

feiss commented 8 years ago

Highlighting the difference between default and changed values can be useful. Two subtle alternatives:

Adding a bullet to the property name: image

Slightly different value color. image

dmarcos commented 8 years ago

It would be better if the changed values pop up even more. What about make the default values grayish and the modified ones blue?

fernandojsg commented 8 years ago

I prefer changing the color of the value instead of adding a bullet next to the name, I also agree with @dmarcos I would prefer something more strong to diferentiate the default values from the rest.

fernandojsg commented 7 years ago

@dmarcos @feiss maybe saving the current blue color for the changed values and use a darker color for the default values?

ngokevin commented 5 years ago

https://github.com/aframevr/aframe-inspector/commit/f4602627f2fd49bb1b56359cdb0c39144dc4b04c