search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
655 stars 203 forks source link

small refactor to component property rendering #193

Closed ngokevin closed 8 years ago

ngokevin commented 8 years ago

Ad-hoc solution for addressing a common complaint. These few properties won't do anything visual from the Editor. So remove them to clean up the noise on one of the more important components.

Decision changed. Only left the refactor.

dmarcos commented 8 years ago

I'm not sure if it's good going down that path. What's the criteria to hide properties? There are just a few properties that are noisy and even in that case the fact that show up in the editor makes them discoverable. What about this? Let's make an editable boolean in the property schema. If editable is false the editor still shows the property but grayed out. It shows the value but it's not modifiable.

ngokevin commented 8 years ago

Yeah, it's very ad-hoc. These are the only three offending properties at the moment. I think this is okay to polish the initial release and then find a scalable solution later (i.e,., allowing components to configure editor appearance).

dmarcos commented 8 years ago

Can we make them non editable instead of hiding them? At least you can see the property and its current value.

ngokevin commented 8 years ago

The issue was more that they are visible in the first place.

So it's usability (modifying relevant properties that have any actual effect in the Editor) vs. property discoverability (seeing all the properties). I think disabling them would help, so people don't try to modify them and see nothing happen, though it'd be slightly weird to expose non-editable properties in the Editor.

What about https://github.com/aframevr/aframe-editor/issues/31 for property discoverability? Since at least component discoverability is not affected by this.

dmarcos commented 8 years ago

It deviates the editor from its purpose of teaching you about components. I don't think that seeing those properties is that big of an issue. They're going to be a tiny fraction of them.

dmarcos commented 8 years ago

Even if those properties are not editable at runtime it can be useful to see their value to diagnose problems. Something could be affecting the appearance of the entities and one of those hidden properties could be the reason. I believe in the hide nothing approach.

fernandojsg commented 8 years ago

I also like the approach of disable them but put everything visible.

ngokevin commented 8 years ago

Fair enough. I have repurposed the PR to just the refactor changes.

ngokevin commented 8 years ago

Rebased.