aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
655 stars 203 forks source link

Attaches editor to the AFRAME global variable #239

Closed dmarcos closed 8 years ago

fernandojsg commented 8 years ago

It will break all the references to editor in the rest of the code.

dmarcos commented 8 years ago

I think your code should not use the externally exposed API

dmarcos commented 8 years ago

changing the public facing API should not affect the code internally

dmarcos commented 8 years ago

I made the editor expose a singleton instead of the constructor. The other modules import it instead of relying in the editor variable of the window object. This way we decouple the internal from the publicly exposed API.

fernandojsg commented 8 years ago

superb! thank you :)