search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

Apply Array.slice to use foreach on nodelists #248

Closed fernandojsg closed 8 years ago

fernandojsg commented 8 years ago

To fix compatibility issues on firefox

darkwing commented 8 years ago

Array.prototype.slice.call(qsa, 0)

fernandojsg commented 8 years ago

@darkwing ah ok, I thought that by default it will take 0, changing! thank you :)

fernandojsg commented 8 years ago

@darkwing I was just checking this https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice and if begin is not defined it will take 0 as default so I believe we don't need to add the extra parameter right?