search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

Introduction of Roboto Mono #272

Closed Coder206 closed 8 years ago

Coder206 commented 8 years ago

This addresses #132, #136 and #160

Coder206 commented 8 years ago

@fernandojsg Instead of using JavaScript, perhaps we could use CSS - it looks a lot simpler to implement? (https://hacks.mozilla.org/2016/06/webfont-preloading-for-html5-games/) What are your thoughts on this?

fernandojsg commented 8 years ago

I don't have an opinion about what could be better, maybe @cvan that opened the issues could help here

Coder206 commented 8 years ago

@fernandojsg @cvan Could I get a status update? (I would like to know the game plan before rebasing)

cvan commented 8 years ago

could you include the commit message in your commit?

Coder206 commented 8 years ago

@cvan What do you mean by commit message? (Doesn't doing git commit -m "Message" qualify as one?)

cvan commented 8 years ago

sorry, I meant Combining CSS queries (fixes #272). but it's not a huge deal 😄

cvan commented 8 years ago

thanks for working on this! it's very close 👍

Coder206 commented 8 years ago

@cvan Thanks the feedback! Looking to competing your requests. I would like to chat with you more about this PR on slack

cvan commented 8 years ago

@Coder206 I didn't understand your question on Slack. could you comment beneath the lines or comments you were unclear on? thanks - and sorry for the delays!

Coder206 commented 8 years ago

@cvan It's fine! I made some comments.

Coder206 commented 8 years ago

@cvan This makes sense!

Coder206 commented 8 years ago

@cvan The changes you requested have been made :)

Coder206 commented 8 years ago

@cvan Done :) (No worries) Works really well on my end. (I took me a while to find the A-Frame code inside the sockjs server code)

cvan commented 8 years ago

r+ this looks perfect - many thanks for your contribution and patience!