search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

Suggestions for new shortcuts #298

Open feiss opened 8 years ago

feiss commented 8 years ago

Following #154 , support for more shortcuts would be very interesting for desktop users.

(Some of these actions are not yet included in the editor, I'll try to write a spec for each one in a separated issue)

Shortcut customization in the cheatsheet panel that #276 suggested would be nice, although I don't think it's high priority.

fernandojsg commented 8 years ago

Thanks! Regarding the esc I was thinking the same but @dmarcos pointed that maybe the VR-scene is capturing esc by itself as it's a very generic shortcut so we can't just hijack it :(

ngokevin commented 8 years ago

When the inspector is active, the scene should be paused and event listeners should be removed, so keypresses should not do anything.

fernandojsg commented 8 years ago

@ngokevin yes that's why esc will works while the editor is opened, but if we exit the inspector and go back to the scene we should remove that listener

feiss commented 8 years ago

Can't you just add the event listener after the vr-scene and its events are initialized? (maybe with a setTimeout()?)

fernandojsg commented 8 years ago

@feiss is not a problem about timing is more a problem on what happens if the vrscene has a listener for esc that does something, if we add a listener we'll screw it, that's why we tend to use rare shortcuts in that situation like ctrl+alt+i.

fernandojsg commented 8 years ago

h to show shortcut cheatsheet

feiss commented 8 years ago

what about the traditional F1? with additional help links and info

fernandojsg commented 8 years ago

F1 is reserved usually by the browser, and for example in mac keyboard you need to click Fn + F1 as F1 by default is assigned to lower screen brightness. Just as completely personal opinion I like having all the shortcuts close to each others so I could have my hand relaxed on the keyboard and just move the fingers to press each shortcut without need to add any movement to my wrist

feiss commented 8 years ago

I'm sold! h then

fernandojsg commented 8 years ago

Maybe backspace for delete? As mac keyboard doesn't have supr by default, you need to press cmd + backspace

fernandojsg commented 8 years ago

@feiss Num +, Num - Do you mean for example translate or rotate step by step? In that case in which axis?

feiss commented 8 years ago

backspace/supr: why not both? num +, num- : no, just visually scaling up/down the helper, without affecting the selection.

fernandojsg commented 8 years ago

backspace/supr: why not both?

Yep!

num +, num- : no, just visually scaling up/down the helper, without affecting the selection.

I don't get that, right now the helper has a constant size, it's not affected by the zoom of the perspective view do you want to make it bigger/smaller? is that useful?

fernandojsg commented 8 years ago

By the way can you update the first comment adding task lists so we could keep checking the ones we're finishing? (https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments)

fernandojsg commented 8 years ago

ctrl+d in windows is add bookmark right? What about using just d without a modifier?

Coder206 commented 8 years ago

@fernandojsg Yes, ctrl+d in Windows adds a bookmark.

feiss commented 8 years ago

allrighty, d without modifier :)

About num+,num-, yup, just change up/down that constant size. You can usually change it in other 3d packages, it's an usability thing. Just think that the transform helper is the most important and used tool of the editor. Anyway, it's not very important, just a small thing.

fernandojsg commented 8 years ago

Updated the list of shortcuts created based on: https://github.com/aframevr/aframe-inspector/pull/305

vershwal commented 7 years ago

@feiss Could you check the copy/paste selection shortcut? https://github.com/aframevr/aframe-inspector/pull/426

feiss commented 7 years ago

@vershwal this is current layout in master. Everything works nice. Fernando even added a cut functionality. Will be available very very soon, thanks! 👍

image

vershwal commented 7 years ago

Yes I saw the cut functionality. It works great.

Also by check I meant ticking the copy/paste dialogue in the issue above (Marking it as resolved). Wrong choice of words I guess.

I think you have checked it.

Thanks