aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

More subtle grid #299

Closed feiss closed 5 years ago

feiss commented 8 years ago

I find the grid very bright and distracting. I suggest flipping its two colors:

Secondary grid lines: Use the current darker gray color of the main axes Main axes lines (x,z): Lighter gray (the current used in the secondary lines of the grid)

fernandojsg commented 8 years ago

Good point! Sadly we should update the current threejs used on aframe as the current release that we're using doesn't support coloring the Grid helper :(

feiss commented 8 years ago

I see... What about drawing the grid by ourselves? It's pretty trivial, I guess..

fernandojsg commented 8 years ago

Yep, I think that finally we'll need to create our own helper. In fact I really like the vizor's grid style.

feiss commented 8 years ago

That one with circles? nope nope please :sweat_smile: I think a grid of parallel lines helps to better perceive the distance and the relation between objects, and gives a better spatial understanding.

fernandojsg commented 8 years ago

You can switch from circles to squares! :P and they have written the distance in the corner.

screenshot 2016-08-18 13 36 56
feiss commented 8 years ago

ok, that's better :D

feiss commented 7 years ago

you can change colors, apparently! http://stackoverflow.com/questions/30162023/gridhelper-axis-different-colours

fernandojsg commented 7 years ago

@feiss Yep, it was a legacy code from the previous versino of threejs where we couldn't change the color, but in the current version is possible to change the color. Just let me know which colors do you prefer and I'll change them ^_^ or feel free to do a PR: https://github.com/aframevr/aframe-inspector/blob/master/src/lib/viewport/index.js#L40

ngokevin commented 5 years ago

https://github.com/aframevr/aframe-inspector/commit/1434c2001f1bee785b3479a062096f4a68048dc7