search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

ComponentLoader should not do a synchronous XHR #313

Closed cvan closed 7 years ago

cvan commented 8 years ago

Never use sync XHRs; they peg the browser.

You could simply make the XHR async, and let this.components get set when the XHR loads, as you're doing already. Is there any other reason why it needs to be synchronous? If there is a reason, can you just use a Promise that resolves/rejects on load/error?

fernandojsg commented 7 years ago

Already fixed with the latest changes from the registry