Change camelCase events to dash-separated for consistency

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.

https://aframe.io/aframe-inspector/examples/

MIT License

654 stars 201 forks source link

Closed fernandojsg closed 7 years ago

fernandojsg commented 7 years ago

Btw I've just noticed that Aframe has componentchanged and child-attached which one should we use? dash-separated right? /cc @ngokevin @dmarcos

ngokevin commented 7 years ago

It's been moving to all lower case, no dashes / spaces. A-Frame codebase is like 50/50 right now, so we just chose one.

fernandojsg commented 7 years ago

Without dashes and lowercase it could looks a little bit ugly for long events:

selected-entity-component-changed => selectedentitycomponentchanged
entity-id-changed => entityidchanged

ngokevin commented 7 years ago

@dmarcos Go dash convention everywhere?

dmarcos commented 7 years ago

I would not use dashes to keep consistency with DOM event names:

fernandojsg commented 7 years ago

Ok, I'll remake the PR to change that way 😢

fernandojsg commented 7 years ago