search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

Broken styles #402

Closed ngokevin closed 6 years ago

ngokevin commented 7 years ago

Working on preparing slides for a meetup. I found the latest Inspector has broken styles. The CSS canvas is not covering the height and width.

I also find clicking objects doesn't work well. I often click on an object, and nothing responds, and I have to fidget with the camera to get it to be selected. (last working at 07550209aee1441f102b4dece6d7464e1867b66f)

1

fernandojsg commented 7 years ago

I've found the same issue on some windows machines, it seems to be related to https://github.com/aframevr/aframe-inspector/blob/master/src/css/main.css#L777 I believe we should use zoom: 1 instead. Could you give it a try in your slides?

ngokevin commented 7 years ago

Yeah, we found this a while back https://github.com/aframevr/aframe-inspector/blob/master/example/embedded-zoom.html

ngokevin commented 7 years ago

Nevermind, different zoom issue.

fernandojsg commented 7 years ago

Yes, with the embedded-zoom example I believed that zoom: reset should works, but now it doesn't seems to work on highres windows. In fact I've found that using 50% zoom on these machines shows the canvas correctly, I don't know why. I should investigate a bit more

kfarr commented 7 years ago

I still see this issue projects with newest aframe master, for example here: screenshot 12

fernandojsg commented 7 years ago

@ngokevin @kfarr could you verify if it's already working correctly with the changes in https://github.com/aframevr/aframe-inspector/pull/421 ?

kfarr commented 7 years ago

I am still seeing the attached, this is using A-Frame Version: 0.4.0 (Date 09-02-2017, Commit #27713c2) on this url http://aframe-city-firebase.surge.sh/nofirebase.html screenshot 45 on firefox nightly and chrome (mainstream release)

kfarr commented 7 years ago

screenshot 8 Chromium latest webvr build (Feb 17) working!

A-Frame Version: 0.5.0 (Date 19-02-2017, Commit #7c011bd)