search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

Added Keyboard events to modify the values of rotation, translation and scaling using keyboard #424

Closed vershwal closed 7 years ago

vershwal commented 7 years ago

It is a common shortcut in softwares like blender to change the transform properties in the three dimensions using the keyboard. This P.R. implements the same.

If you press 'r', you go to the scaling mode. Now pressing 'x' followed by a numerical value modifies the scale in the x direction to that value on pressing enter.

Similarly for other transform properties and dimensions.

vershwal commented 7 years ago

Hi @fernandojsg

I have implemented a shortcut feature for aframe-inspector. Could you review the P.R.?

fernandojsg commented 7 years ago

While it's a nice feature I think it's a bit overkill feature right now for the current target of the inspector, probably if in the future the editor would evolve in something more like a content creation and composition tool instead of a devtool it could makes more sense. What do you think @feiss ?

feiss commented 7 years ago

Yeah, I agree. It is a nice feature and well implemented, but it is quite hardcore for the current status of the inspector, it is not prepared for this interaction level (yet).

It will be interesting to reopen this PR in the future, for sure

fernandojsg commented 7 years ago

Thanks. Ok so let's close it by now and we'll reopen it in the future if we seems to evolve in that way.

vershwal commented 7 years ago

Thanks for the review. Glad you guys liked it.

Yes I have to agree this P.R. might not be a very valuable addition to the inspector. Its more of a compositor feature.