search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
655 stars 203 forks source link

saveSceneToHTML() exports with an inactive camera, making an empty looking scene #433

Closed Utopiah closed 5 years ago

Utopiah commented 7 years ago

It's possible to fix it starting and closing the inspector or making the camera active document.getElementById('camera').setAttribute("camera", "active:true") but it would be more natural to change the camera to active on export (either on saveSceneToHTML() or even generateHtml().

fernandojsg commented 7 years ago

@Utopiah that should be fixed with the latest changes, do you mind giving it a try?

Utopiah commented 7 years ago

Tried using master and it works, namely the scene is visible but it's not using the existing camera as it is still marked active:false thus injects a new camera. Not sure if that's the intended behavior.

fernandojsg commented 7 years ago

Ah ok I see. I was just deleting the default camera injected by the editor, but you're right that I need to remove the active:false on the default camera.

ngokevin commented 5 years ago

https://github.com/aframevr/aframe-inspector/issues/517#issuecomment-445454902