aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

aframe-inspector.min.js:30 Uncaught TypeError: Cannot read property 'pause' of undefined at open (aframe-inspector.min.js:30) at HTMLScriptElement.script.onload (inspector.js:85) #479

Closed ngokevin closed 7 years ago

ngokevin commented 7 years ago

Opening Inspector from A-Frame repo examples. Both with and without INSPECTOR_VERSION=dev. Fails using aframe-inspector repo dist as well as Inspector v0.5.2.

ngokevin commented 7 years ago

I got it to work once on Inspector v0.5.2, so it's a bit intermittent. Usually fails though.

fernandojsg commented 7 years ago

@ngokevin do you mind explaining how to reproduce it? I've tried both on the aframe.io and locally on aframe master and I can't reproduce it.

fernandojsg commented 7 years ago

Ok, I found that error on a-painter

fernandojsg commented 7 years ago

stupid bug, I believe it's already fixed by https://github.com/aframevr/aframe-inspector/commit/760796ccc6e12f9508296aae75ff084284598257 Could you verify it?

fernandojsg commented 7 years ago

/ping @ngokevin :)

ngokevin commented 7 years ago

I'm still getting it. Local aframe repo, master branch, npm run dev, port 9000

fernandojsg commented 7 years ago

I've just tried with master branch on mac both with chrome and firefox, refreshing several times but can't reproduce it :\ inspector2 inspector

Maybe you're having an issue with the cache?

ngokevin commented 7 years ago

Hm, doubt it. I've tried 11 days apart on different networks with hard refreshes.

fix

ngokevin commented 7 years ago

And Firefox this.sceneEl is undefined

ff

fernandojsg commented 7 years ago

Poltergeist :\ I've used the same example from the text. It seems we've the same versions too. Are you on windows?

Also It seems that the error is different in your firefox and chrome, one is regarding .pause in the modules and another one is about sceneEl

inspector3

ngokevin commented 7 years ago

It's the same error. this.sceneEl is undefined and cannot call pause of undefined. Trying to call this.sceneEl.pause(). I'm on OS X

fernandojsg commented 7 years ago

Could you try to use the non minified version and set a breakpoint? I'm looking at the code and the only place where you get that call is at: https://github.com/aframevr/aframe-inspector/blob/gh-pages/src/lib/inspector.js#L310 And before calling it we've already query the a-scene here https://github.com/aframevr/aframe-inspector/blob/gh-pages/src/lib/inspector.js#L28-L33 Not sure what is going on there

fernandojsg commented 7 years ago

@dmarcos @feiss @delapuente do you mind giving it a try? I can't find a way to reproduce it maybe you could get the same issue as kevin is having right now?

dmarcos commented 7 years ago

Running the inspector master: npm start and visiting http://localhost:3333/webpack-dev-server/. does not show any errors for me. I opened / closed the inspector multiple times and tried on Firefox and Chrome. Am I trying this right?

fernandojsg commented 7 years ago

@dmarcos sorry I didn't expressed it correctly. You should try aframe master, not the inspector itself. Just test aframe master and inject the inspector there

dmarcos commented 7 years ago

I cannot reproduce the problem either running master inspector on aframe master examples bug

feiss commented 7 years ago

git clone [aframe repo] npm install && npm run dev opened a couple of examples, entered inspector, and I got no errors about pause()

delapuente commented 7 years ago

Same try as @feiss Everything is fine in Mac OS in both Nightly and Canary and the same in Windows. No errors regarding pause().

fernandojsg commented 7 years ago

@feiss @dmarcos @delapuente thank you guys!

@ngokevin could you try in another computer? I've no idea what can be wrong but impossible to reproduce here either :\

fernandojsg commented 7 years ago

I'll close it as I can't reproduce it anywhere the same as the rest :\ If you have a way to reproduce it please reopen it again